Skip to content

Use string instead of HSMRejectedReason enum in Integration template response #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

Use string instead of HSMRejectedReason enum in Integration template response #185

merged 1 commit into from
Jan 19, 2022

Conversation

olimpias
Copy link
Contributor

rejectedReason could be a custom string. We need to support every possible rejected reason results

@olimpias
Copy link
Contributor Author

Hey @denizkilic , could you review this MR? Thanks!

@denizkilic
Copy link
Contributor

LGTM!

@denizkilic denizkilic merged commit edc8020 into messagebird:master Jan 19, 2022
@denizkilic denizkilic mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olimpias @denizkilic